Name the probed decoder address in fr24 reachability errors#105
Merged
Conversation
The fr24 enable/reset gates hardcoded 127.0.0.1:30005 in the decoder_unavailable message while the probe checks AGG_DECODER_ADDR and the piaware path already names it. Use the variable so the message reflects what was actually probed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FlightRadar24 enable and reconfigure paths reported
local decoder 127.0.0.1:30005 is not reachablewith the address baked into the string, even though the reachability probe actually checksAGG_DECODER_ADDR(and the FlightAware path already names that). This makes the FR24 message name the address that was probed, so all four decoder-unavailable messages read consistently.No behaviour change on a default install — the value is identical.